aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorMichael Paquier <michael@paquier.xyz>2024-06-17 14:26:27 +0900
committerMichael Paquier <michael@paquier.xyz>2024-06-17 14:26:27 +0900
commit8f1888eb6d6023b80525fbf7a8a1053daa6eb31e (patch)
treec62245402346b8e71744637112049c247fe9fd94 /src
parentfaaa0d279899f037b4a6472a00fcd14a321e64c7 (diff)
downloadpostgresql-8f1888eb6d6023b80525fbf7a8a1053daa6eb31e.tar.gz
postgresql-8f1888eb6d6023b80525fbf7a8a1053daa6eb31e.zip
Make regress function make_tuple_indirect() able to handle plain attributes
The function has been introduced in 368202501539 to test at a low level the new kinds of external toast datums, and would fail on OOM when dealing with a plain storage attribute. The existing tests of indirect_toast do not test this case, still the error generated was confusing. Author: Alexander Lakhin Discussion: https://postgr.es/m/250a21e5-d677-6b2a-2692-cd4233785e37@gmail.com
Diffstat (limited to 'src')
-rw-r--r--src/test/regress/regress.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/test/regress/regress.c b/src/test/regress/regress.c
index deffaea578b..45a6ad3c49e 100644
--- a/src/test/regress/regress.c
+++ b/src/test/regress/regress.c
@@ -595,7 +595,8 @@ make_tuple_indirect(PG_FUNCTION_ARGS)
/* only work on existing, not-null varlenas */
if (TupleDescAttr(tupdesc, i)->attisdropped ||
nulls[i] ||
- TupleDescAttr(tupdesc, i)->attlen != -1)
+ TupleDescAttr(tupdesc, i)->attlen != -1 ||
+ TupleDescAttr(tupdesc, i)->attstorage == TYPSTORAGE_PLAIN)
continue;
attr = (struct varlena *) DatumGetPointer(values[i]);