diff options
| author | Fujii Masao <fujii@postgresql.org> | 2016-08-01 17:36:14 +0900 |
|---|---|---|
| committer | Fujii Masao <fujii@postgresql.org> | 2016-08-01 17:37:18 +0900 |
| commit | 928e92fda30fa61688534802c849797c9986dc4c (patch) | |
| tree | d60e35128063dd83f59882efb7938b6138e6a93c /src | |
| parent | c0782a147390d11eab8387fd612b15d5ec6d5240 (diff) | |
| download | postgresql-928e92fda30fa61688534802c849797c9986dc4c.tar.gz postgresql-928e92fda30fa61688534802c849797c9986dc4c.zip | |
Fix pg_basebackup so that it accepts 0 as a valid compression level.
The help message for pg_basebackup specifies that the numbers 0 through 9
are accepted as valid values of -Z option. But, previously -Z 0 was rejected
as an invalid compression level.
Per discussion, it's better to make pg_basebackup treat 0 as valid
compression level meaning no compression, like pg_dump.
Back-patch to all supported versions.
Reported-By: Jeff Janes
Reviewed-By: Amit Kapila
Discussion: CAMkU=1x+GwjSayc57v6w87ij6iRGFWt=hVfM0B64b1_bPVKRqg@mail.gmail.com
Diffstat (limited to 'src')
| -rw-r--r-- | src/bin/pg_basebackup/pg_basebackup.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/bin/pg_basebackup/pg_basebackup.c b/src/bin/pg_basebackup/pg_basebackup.c index 86e18f6e61b..84eef6466d7 100644 --- a/src/bin/pg_basebackup/pg_basebackup.c +++ b/src/bin/pg_basebackup/pg_basebackup.c @@ -2050,7 +2050,7 @@ main(int argc, char **argv) break; case 'Z': compresslevel = atoi(optarg); - if (compresslevel <= 0 || compresslevel > 9) + if (compresslevel < 0 || compresslevel > 9) { fprintf(stderr, _("%s: invalid compression level \"%s\"\n"), progname, optarg); |