Revert "Add test case for obsoleting slot with active walsender"

This reverts commit 09126984a263; the test case added there failed once
in circumstances that remain mysterious.  It seems better to remove the
test for now so that 14beta2 doesn't have random failures built in.

1 files changed, 3 insertions, 82 deletions

diff --git a/src/test/recovery/t/019_replslot_limit.pl b/src/test/recovery/t/019_replslot_limit.pl
index 5e25661e105..7094aa0704b 100644
--- a/src/test/recovery/t/019_replslot_limit.pl
+++ b/src/test/recovery/t/019_replslot_limit.pl
@@ -11,7 +11,7 @@ use TestLib;
 use PostgresNode;
 
 use File::Path qw(rmtree);
-use Test::More tests => $TestLib::windows_os ? 14 : 18;
+use Test::More tests => 14;
 use Time::HiRes qw(usleep);
 
 $ENV{PGDATABASE} = 'postgres';
@@ -211,8 +211,8 @@ for (my $i = 0; $i < 10000; $i++)
 }
 ok($failed, 'check that replication has been broken');
 
-$node_primary->stop;
-$node_standby->stop;
+$node_primary->stop('immediate');
+$node_standby->stop('immediate');
 
 my $node_primary2 = get_new_node('primary2');
 $node_primary2->init(allows_streaming => 1);
@@ -253,85 +253,6 @@ my @result =
 		timeout => '60'));
 is($result[1], 'finished', 'check if checkpoint command is not blocked');
 
-$node_primary2->stop;
-$node_standby->stop;
-
-# The next test depends on Perl's `kill`, which apparently is not
-# portable to Windows.  (It would be nice to use Test::More's `subtest`,
-# but that's not in the ancient version we require.)
-if ($TestLib::windows_os)
-{
-	done_testing();
-	exit;
-}
-
-# Get a slot terminated while the walsender is active
-# We do this by sending SIGSTOP to the walsender.  Skip this on Windows.
-my $node_primary3 = get_new_node('primary3');
-$node_primary3->init(allows_streaming => 1, extra => ['--wal-segsize=1']);
-$node_primary3->append_conf(
-	'postgresql.conf', qq(
-	min_wal_size = 2MB
-	max_wal_size = 2MB
-	log_checkpoints = yes
-	max_slot_wal_keep_size = 1MB
-	));
-$node_primary3->start;
-$node_primary3->safe_psql('postgres',
-	"SELECT pg_create_physical_replication_slot('rep3')");
-# Take backup
-$backup_name = 'my_backup';
-$node_primary3->backup($backup_name);
-# Create standby
-my $node_standby3 = get_new_node('standby_3');
-$node_standby3->init_from_backup($node_primary3, $backup_name,
-	has_streaming => 1);
-$node_standby3->append_conf('postgresql.conf', "primary_slot_name = 'rep3'");
-$node_standby3->start;
-$node_primary3->wait_for_catchup($node_standby3->name, 'replay');
-my $senderpid = $node_primary3->safe_psql('postgres',
-	"SELECT pid FROM pg_stat_activity WHERE backend_type = 'walsender'");
-like($senderpid, qr/^[0-9]+$/, "have walsender pid $senderpid");
-my $receiverpid = $node_standby3->safe_psql('postgres',
-	"SELECT pid FROM pg_stat_activity WHERE backend_type = 'walreceiver'");
-like($receiverpid, qr/^[0-9]+$/, "have walreceiver pid $receiverpid");
-
-# freeze walsender and walreceiver. Slot will still be active, but walreceiver
-# won't get anything anymore.
-kill 'STOP', $senderpid, $receiverpid;
-$logstart = get_log_size($node_primary3);
-advance_wal($node_primary3, 4);
-ok(find_in_log($node_primary3, "to release replication slot", $logstart),
-	"walreceiver termination logged");
-
-# Now let the walsender continue; slot should be killed now.
-# (Must not let walreceiver run yet; otherwise the standby could start another
-# one before the slot can be killed)
-kill 'CONT', $senderpid;
-$node_primary3->poll_query_until('postgres',
-	"SELECT wal_status FROM pg_replication_slots WHERE slot_name = 'rep3'",
-	"lost")
-  or die "timed out waiting for slot to be lost";
-
-my $max_attempts = 180;
-while ($max_attempts-- > 0)
-{
-	if (find_in_log(
-			$node_primary3,
-			'invalidating slot "rep3" because its restart_lsn', $logstart))
-	{
-		ok(1, "slot invalidation logged");
-		last;
-	}
-	sleep 1;
-}
-
-# Now let the walreceiver continue, so that the node can be stopped cleanly
-kill 'CONT', $receiverpid;
-
-$node_primary3->stop;
-$node_standby3->stop;
-
 #####################################
 # Advance WAL of $node by $n segments
 sub advance_wal