aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorAlvaro Herrera <alvherre@alvh.no-ip.org>2007-09-10 17:59:03 +0000
committerAlvaro Herrera <alvherre@alvh.no-ip.org>2007-09-10 17:59:03 +0000
commita441035198a8abe9e41fc086f5d14e7f0cab6efc (patch)
tree9f009ccb06863547a0996caba3db01ee842dd25a /src
parent43e398900d179a56f478f903bdde0d3d41265d51 (diff)
downloadpostgresql-a441035198a8abe9e41fc086f5d14e7f0cab6efc.tar.gz
postgresql-a441035198a8abe9e41fc086f5d14e7f0cab6efc.zip
Remove the vacuum_delay_point call in count_nondeletable_pages, because we hold
an exclusive lock on the table at this point, which we want to release as soon as possible. This is called in the phase of lazy vacuum where we truncate the empty pages at the end of the table. An alternative solution would be to lower the vacuum delay settings before starting the truncating phase, but this doesn't work very well in autovacuum due to the autobalancing code (which can cause other processes to change our cost delay settings). This case could be considered in the balancing code, but it is simpler this way.
Diffstat (limited to 'src')
-rw-r--r--src/backend/commands/vacuumlazy.c8
1 files changed, 6 insertions, 2 deletions
diff --git a/src/backend/commands/vacuumlazy.c b/src/backend/commands/vacuumlazy.c
index 516e53af299..182c0e46379 100644
--- a/src/backend/commands/vacuumlazy.c
+++ b/src/backend/commands/vacuumlazy.c
@@ -31,7 +31,7 @@
*
*
* IDENTIFICATION
- * $PostgreSQL: pgsql/src/backend/commands/vacuumlazy.c,v 1.50.4.2 2005/05/07 21:32:53 tgl Exp $
+ * $PostgreSQL: pgsql/src/backend/commands/vacuumlazy.c,v 1.50.4.3 2007/09/10 17:59:03 alvherre Exp $
*
*-------------------------------------------------------------------------
*/
@@ -863,7 +863,11 @@ count_nondeletable_pages(Relation onerel, LVRelStats *vacrelstats)
bool tupgone,
hastup;
- vacuum_delay_point();
+ /*
+ * We don't insert a vacuum delay point here, because we have an
+ * exclusive lock on the table which we want to hold for as short
+ * a time as possible.
+ */
blkno--;