diff options
| author | Michael Paquier <michael@paquier.xyz> | 2023-07-03 10:06:19 +0900 |
|---|---|---|
| committer | Michael Paquier <michael@paquier.xyz> | 2023-07-03 10:06:19 +0900 |
| commit | af36c13a7e92863413c433d3acd8aea62b216e9a (patch) | |
| tree | 35db579e7e00f4e23e73767aa908702187d7a936 /src | |
| parent | dbe0e5c56f313aec94cd8cf0c4f922867b2a95c5 (diff) | |
| download | postgresql-af36c13a7e92863413c433d3acd8aea62b216e9a.tar.gz postgresql-af36c13a7e92863413c433d3acd8aea62b216e9a.zip | |
Make PG_TEST_NOCLEAN work for temporary directories in TAP tests
When set, this environment variable was only effective for data
directories but not for all the other temporary files created by
PostgreSQL::Test::Utils. Keeping the temporary files after a successful
run can be useful for debugging purposes.
The documentation is updated to reflect the new behavior, with contents
available in doc/ since v16 and in src/test/perl/README since v15.
Author: Jacob Champion
Reviewed-by: Daniel Gustafsson
Discussion: https://postgr.es/m/CAAWbhmgHtDH1SGZ+Fw05CsXtE0mzTmjbuUxLB9mY9iPKgM6cUw@mail.gmail.com
Discussion: https://postgr.es/m/YyPd9unV14SX2bLF@paquier.xyz
Backpatch-through: 11
Diffstat (limited to 'src')
| -rw-r--r-- | src/test/perl/TestLib.pm | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/test/perl/TestLib.pm b/src/test/perl/TestLib.pm index 237bacfc7b8..de851e16156 100644 --- a/src/test/perl/TestLib.pm +++ b/src/test/perl/TestLib.pm @@ -187,7 +187,7 @@ sub tempdir return File::Temp::tempdir( $prefix . '_XXXX', DIR => $tmp_check, - CLEANUP => 1); + CLEANUP => not defined $ENV{'PG_TEST_NOCLEAN'}); } sub tempdir_short @@ -195,7 +195,8 @@ sub tempdir_short # Use a separate temp dir outside the build tree for the # Unix-domain socket, to avoid file name length issues. - return File::Temp::tempdir(CLEANUP => 1); + return File::Temp::tempdir( + CLEANUP => not defined $ENV{'PG_TEST_NOCLEAN'}); } =pod |