diff options
| author | Michael Paquier <michael@paquier.xyz> | 2024-07-01 09:35:36 +0900 |
|---|---|---|
| committer | Michael Paquier <michael@paquier.xyz> | 2024-07-01 09:35:36 +0900 |
| commit | b19db55bd687af243dd1edf021ffb166e5270a06 (patch) | |
| tree | 668507054a81019c77193cb8af534ff785785847 /src | |
| parent | 1029bdec2d641f378eaa59f00a93b136f191f3c7 (diff) | |
| download | postgresql-b19db55bd687af243dd1edf021ffb166e5270a06.tar.gz postgresql-b19db55bd687af243dd1edf021ffb166e5270a06.zip | |
Remove PgStat_KindInfo.named_on_disk
This field is used to track if a stats kind can use a custom format
representation on disk when reading or writing its stats case. On HEAD,
this exists for replication slots stats, that need a mapping between an
internal index ID and the slot names.
named_on_disk is currently used nowhere and the callbacks
to_serialized_name and from_serialized_name are in charge of checking if
the serialization of the stats data should apply, so let's remove it.
Reviewed-by: Andres Freund
Discussion: https://postgr.es/m/ZmKVlSX_T5YvIOsd@paquier.xyz
Diffstat (limited to 'src')
| -rw-r--r-- | src/backend/utils/activity/pgstat.c | 1 | ||||
| -rw-r--r-- | src/include/utils/pgstat_internal.h | 8 |
2 files changed, 1 insertions, 8 deletions
diff --git a/src/backend/utils/activity/pgstat.c b/src/backend/utils/activity/pgstat.c index dcc2ad8d954..44f0d3ede72 100644 --- a/src/backend/utils/activity/pgstat.c +++ b/src/backend/utils/activity/pgstat.c @@ -307,7 +307,6 @@ static const PgStat_KindInfo pgstat_kind_infos[PGSTAT_NUM_KINDS] = { .fixed_amount = false, .accessed_across_databases = true, - .named_on_disk = true, .shared_size = sizeof(PgStatShared_ReplSlot), .shared_data_off = offsetof(PgStatShared_ReplSlot, stats), diff --git a/src/include/utils/pgstat_internal.h b/src/include/utils/pgstat_internal.h index dbbca316025..f6031995a9d 100644 --- a/src/include/utils/pgstat_internal.h +++ b/src/include/utils/pgstat_internal.h @@ -194,12 +194,6 @@ typedef struct PgStat_KindInfo bool accessed_across_databases:1; /* - * For variable-numbered stats: Identified on-disk using a name, rather - * than PgStat_HashKey. Probably only needed for replication slot stats. - */ - bool named_on_disk:1; - - /* * The size of an entry in the shared stats hash table (pointed to by * PgStatShared_HashEntry->body). */ @@ -239,7 +233,7 @@ typedef struct PgStat_KindInfo void (*reset_timestamp_cb) (PgStatShared_Common *header, TimestampTz ts); /* - * For variable-numbered stats with named_on_disk. Optional. + * For variable-numbered stats. Optional. */ void (*to_serialized_name) (const PgStat_HashKey *key, const PgStatShared_Common *header, NameData *name); |