aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorTom Lane <tgl@sss.pgh.pa.us>2022-08-13 15:21:28 -0400
committerTom Lane <tgl@sss.pgh.pa.us>2022-08-13 15:21:28 -0400
commitba516fb0715c75b1b2d393c3de7b99fca6a1ac67 (patch)
treeb2144fbc5cc124d9bb40060dd1a28f90a2408e32 /src
parent1f71861a85404f8417c1b60419d813f8721f445c (diff)
downloadpostgresql-ba516fb0715c75b1b2d393c3de7b99fca6a1ac67.tar.gz
postgresql-ba516fb0715c75b1b2d393c3de7b99fca6a1ac67.zip
Catch stack overflow when recursing in transformFromClauseItem().
Most parts of the parser can expect that the stack overflow check in transformExprRecurse() will trigger before things get desperate. However, transformFromClauseItem() can recurse directly to self without having analyzed any expressions, so it's possible to drive it to a stack-overrun crash. Add a check to prevent that. Per bug #17583 from Egor Chindyaskin. Back-patch to all supported branches. Richard Guo Discussion: https://postgr.es/m/17583-33be55b9f981f75c@postgresql.org
Diffstat (limited to 'src')
-rw-r--r--src/backend/parser/parse_clause.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/src/backend/parser/parse_clause.c b/src/backend/parser/parse_clause.c
index 7e9216142a1..0a0d68f0e75 100644
--- a/src/backend/parser/parse_clause.c
+++ b/src/backend/parser/parse_clause.c
@@ -1066,6 +1066,9 @@ transformFromClauseItem(ParseState *pstate, Node *n,
RangeTblEntry **top_rte, int *top_rti,
List **namespace)
{
+ /* Guard against stack overflow due to overly deep subtree */
+ check_stack_depth();
+
if (IsA(n, RangeVar))
{
/* Plain relation reference, or perhaps a CTE reference */