diff options
| author | Amit Kapila <akapila@postgresql.org> | 2021-06-07 09:32:06 +0530 |
|---|---|---|
| committer | Amit Kapila <akapila@postgresql.org> | 2021-06-07 09:32:06 +0530 |
| commit | be57f21650d36449ec34a67b2d9af71126a663b3 (patch) | |
| tree | 134256ec480a913b5be00b40458568932ed10076 /src | |
| parent | f3baaf28a6da588987b94a05a725894805c3eae9 (diff) | |
| download | postgresql-be57f21650d36449ec34a67b2d9af71126a663b3.tar.gz postgresql-be57f21650d36449ec34a67b2d9af71126a663b3.zip | |
Remove two_phase variable from CreateReplicationSlotCmd struct.
Commit 19890a064e added the option to enable two_phase commits via
pg_create_logical_replication_slot but didn't extend the support of same
in replication protocol. However, by mistake, it added the two_phase
variable in CreateReplicationSlotCmd which is required only when we extend
the replication protocol.
Reported-by: Jeff Davis
Author: Ajin Cherian
Reviewed-by: Amit Kapila
Discussion: https://postgr.es/m/64b9f783c6e125f18f88fbc0c0234e34e71d8639.camel@j-davis.com
Diffstat (limited to 'src')
| -rw-r--r-- | src/backend/replication/walsender.c | 2 | ||||
| -rw-r--r-- | src/include/nodes/replnodes.h | 1 |
2 files changed, 1 insertions, 2 deletions
diff --git a/src/backend/replication/walsender.c b/src/backend/replication/walsender.c index e94069c366a..109c723f4e1 100644 --- a/src/backend/replication/walsender.c +++ b/src/backend/replication/walsender.c @@ -954,7 +954,7 @@ CreateReplicationSlot(CreateReplicationSlotCmd *cmd) */ ReplicationSlotCreate(cmd->slotname, true, cmd->temporary ? RS_TEMPORARY : RS_EPHEMERAL, - cmd->two_phase); + false); } if (cmd->kind == REPLICATION_KIND_LOGICAL) diff --git a/src/include/nodes/replnodes.h b/src/include/nodes/replnodes.h index ebc43a0293d..faa3a251f26 100644 --- a/src/include/nodes/replnodes.h +++ b/src/include/nodes/replnodes.h @@ -56,7 +56,6 @@ typedef struct CreateReplicationSlotCmd ReplicationKind kind; char *plugin; bool temporary; - bool two_phase; List *options; } CreateReplicationSlotCmd; |