diff options
| author | Heikki Linnakangas <heikki.linnakangas@iki.fi> | 2023-08-23 18:08:40 +0300 |
|---|---|---|
| committer | Heikki Linnakangas <heikki.linnakangas@iki.fi> | 2023-08-23 18:11:51 +0300 |
| commit | c3b874c431bc5d1399c011e9e5ce1e30b756f930 (patch) | |
| tree | 3de1820d161bebd12b5970bd52804331ff52f241 /src | |
| parent | 6bc1fd4e60e9556ba5e04710049fdf42e3134f47 (diff) | |
| download | postgresql-c3b874c431bc5d1399c011e9e5ce1e30b756f930.tar.gz postgresql-c3b874c431bc5d1399c011e9e5ce1e30b756f930.zip | |
Fix _bt_allequalimage() call within critical section.
_bt_allequalimage() does complicated things, so it's not OK to call it
in a critical section. Per buildfarm failure on 'prion', which uses
-DRELCACHE_FORCE_RELEASE -DCATCACHE_FORCE_RELEASE options.
Discussion: https://www.postgresql.org/message-id/6e5bbc08-cdfc-b2b3-9e23-1a914b9850a9@iki.fi
Backpatch-through: 16, like commit ccadf73163 that introduced this
Diffstat (limited to 'src')
| -rw-r--r-- | src/backend/access/nbtree/nbtree.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/backend/access/nbtree/nbtree.c b/src/backend/access/nbtree/nbtree.c index ad07b80f758..62bc9917f13 100644 --- a/src/backend/access/nbtree/nbtree.c +++ b/src/backend/access/nbtree/nbtree.c @@ -151,6 +151,7 @@ bthandler(PG_FUNCTION_ARGS) void btbuildempty(Relation index) { + bool allequalimage = _bt_allequalimage(index, false); Buffer metabuf; Page metapage; @@ -169,7 +170,7 @@ btbuildempty(Relation index) START_CRIT_SECTION(); metapage = BufferGetPage(metabuf); - _bt_initmetapage(metapage, P_NONE, 0, _bt_allequalimage(index, false)); + _bt_initmetapage(metapage, P_NONE, 0, allequalimage); MarkBufferDirty(metabuf); log_newpage_buffer(metabuf, true); |