aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorNoah Misch <noah@leadboat.com>2018-09-08 18:26:10 -0700
committerNoah Misch <noah@leadboat.com>2018-09-08 18:26:10 -0700
commitc85ad9cc63e1487758f3969e20826cac0e944a27 (patch)
tree3c2f95e12c71c2e66655dfd6dfd0203856339a2f /src
parent076a3c2112b127b3b36346dbc64659f9a165f60f (diff)
downloadpostgresql-c85ad9cc63e1487758f3969e20826cac0e944a27.tar.gz
postgresql-c85ad9cc63e1487758f3969e20826cac0e944a27.zip
Allow ENOENT in check_mode_recursive().
Buildfarm member tern failed src/bin/pg_ctl/t/001_start_stop.pl when a check_mode_recursive() call overlapped a server's startup-time deletion of pg_stat/global.stat. Just warn. Also, include errno in the message. Back-patch to v11, where check_mode_recursive() first appeared.
Diffstat (limited to 'src')
-rw-r--r--src/test/perl/TestLib.pm21
1 files changed, 17 insertions, 4 deletions
diff --git a/src/test/perl/TestLib.pm b/src/test/perl/TestLib.pm
index 3a184a4fadd..b9cb51b9d39 100644
--- a/src/test/perl/TestLib.pm
+++ b/src/test/perl/TestLib.pm
@@ -261,8 +261,6 @@ sub check_mode_recursive
{
follow_fast => 1,
wanted => sub {
- my $file_stat = stat($File::Find::name);
-
# Is file in the ignore list?
foreach my $ignore ($ignore_list ? @{$ignore_list} : [])
{
@@ -272,8 +270,23 @@ sub check_mode_recursive
}
}
- defined($file_stat)
- or die("unable to stat $File::Find::name");
+ # Allow ENOENT. A running server can delete files, such as
+ # those in pg_stat. Other stat() failures are fatal.
+ my $file_stat = stat($File::Find::name);
+ unless (defined($file_stat))
+ {
+ my $is_ENOENT = $!{ENOENT};
+ my $msg = "unable to stat $File::Find::name: $!";
+ if ($is_ENOENT)
+ {
+ warn $msg;
+ return;
+ }
+ else
+ {
+ die $msg;
+ }
+ }
my $file_mode = S_IMODE($file_stat->mode);