diff options
| author | Noah Misch <noah@leadboat.com> | 2024-06-28 09:33:40 -0700 |
|---|---|---|
| committer | Noah Misch <noah@leadboat.com> | 2024-06-28 09:33:44 -0700 |
| commit | ca30e8ba958a60b9179f018052cc8959d38ffa8e (patch) | |
| tree | b71020015dff3d94b31e571dc3285ecdc3fc3844 /src | |
| parent | c63ceb2f0006c9549f0a4270d41dda37bbbe983f (diff) | |
| download | postgresql-ca30e8ba958a60b9179f018052cc8959d38ffa8e.tar.gz postgresql-ca30e8ba958a60b9179f018052cc8959d38ffa8e.zip | |
Remove configuration-dependent output from new inplace-inval test.
Per buildfarm members prion and trilobite. Back-patch to v12 (all
supported versions), like commit
0844b3968985447ed0a6937cfc8639e379da2fe6.
Strategy reviewed by Tom Lane.
Discussion: https://postgr.es/m/20240628051353.a0.nmisch@google.com
Diffstat (limited to 'src')
| -rw-r--r-- | src/test/isolation/expected/inplace-inval.out | 10 | ||||
| -rw-r--r-- | src/test/isolation/specs/inplace-inval.spec | 4 |
2 files changed, 4 insertions, 10 deletions
diff --git a/src/test/isolation/expected/inplace-inval.out b/src/test/isolation/expected/inplace-inval.out index 67b34ad20ca..e68eca5de98 100644 --- a/src/test/isolation/expected/inplace-inval.out +++ b/src/test/isolation/expected/inplace-inval.out @@ -1,6 +1,6 @@ Parsed test spec with 3 sessions -starting permutation: cachefill3 cir1 cic2 ddl3 read1 +starting permutation: cachefill3 cir1 cic2 ddl3 step cachefill3: TABLE newly_indexed; c - @@ -9,14 +9,6 @@ c step cir1: BEGIN; CREATE INDEX i1 ON newly_indexed (c); ROLLBACK; step cic2: CREATE INDEX i2 ON newly_indexed (c); step ddl3: ALTER TABLE newly_indexed ADD extra int; -step read1: - SELECT relhasindex FROM pg_class WHERE oid = 'newly_indexed'::regclass; - -relhasindex ------------ -f -(1 row) - starting permutation: cir1 cic2 ddl3 read1 step cir1: BEGIN; CREATE INDEX i1 ON newly_indexed (c); ROLLBACK; diff --git a/src/test/isolation/specs/inplace-inval.spec b/src/test/isolation/specs/inplace-inval.spec index d8e1c98b8e9..96954fd86c4 100644 --- a/src/test/isolation/specs/inplace-inval.spec +++ b/src/test/isolation/specs/inplace-inval.spec @@ -27,12 +27,14 @@ step cachefill3 { TABLE newly_indexed; } step ddl3 { ALTER TABLE newly_indexed ADD extra int; } +# XXX shows an extant bug. Adding step read1 at the end would usually print +# relhasindex=f (not wanted). This does not reach the unwanted behavior under +# -DCATCACHE_FORCE_RELEASE and friends. permutation cachefill3 # populates the pg_class row in the catcache cir1 # sets relhasindex=true; rollback discards cache inval cic2 # sees relhasindex=true, skips changing it (so no inval) ddl3 # cached row as the oldtup of an update, losing relhasindex - read1 # observe damage XXX is an extant bug # without cachefill3, no bug permutation cir1 cic2 ddl3 read1 |