aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorPeter Eisentraut <peter_e@gmx.net>2018-04-14 10:04:36 -0400
committerPeter Eisentraut <peter_e@gmx.net>2018-04-14 10:04:36 -0400
commite013288a6509549866c5d531257480f159c6900d (patch)
tree12479faeba0d6713c8a56dccf27821f4d9b9b37c /src
parenta8677e3ff6bb8ef78a9ba676faa647bba237b1c4 (diff)
downloadpostgresql-e013288a6509549866c5d531257480f159c6900d.tar.gz
postgresql-e013288a6509549866c5d531257480f159c6900d.zip
Improve code comments
As of 0c2c81b403db420bfce36f168887db72932dbf09, the replication parameter in libpq is no longer "deliberately undocumented".
Diffstat (limited to 'src')
-rw-r--r--src/backend/replication/libpqwalreceiver/libpqwalreceiver.c9
1 files changed, 5 insertions, 4 deletions
diff --git a/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c b/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c
index ec37377efe5..e4d261bd793 100644
--- a/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c
+++ b/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c
@@ -128,10 +128,7 @@ libpqrcv_connect(const char *conninfo, bool logical, const char *appname,
/*
* We use the expand_dbname parameter to process the connection string (or
- * URI), and pass some extra options. The deliberately undocumented
- * parameter "replication=true" makes it a replication connection. The
- * database name is ignored by the server in replication mode, but specify
- * "replication" for .pgpass lookup.
+ * URI), and pass some extra options.
*/
keys[i] = "dbname";
vals[i] = conninfo;
@@ -139,6 +136,10 @@ libpqrcv_connect(const char *conninfo, bool logical, const char *appname,
vals[i] = logical ? "database" : "true";
if (!logical)
{
+ /*
+ * The database name is ignored by the server in replication mode, but
+ * specify "replication" for .pgpass lookup.
+ */
keys[++i] = "dbname";
vals[i] = "replication";
}