diff options
| author | Andres Freund <andres@anarazel.de> | 2016-03-05 18:02:20 -0800 |
|---|---|---|
| committer | Andres Freund <andres@anarazel.de> | 2016-03-05 18:02:20 -0800 |
| commit | e76e365be9e7fc30f19d21962461a0046d15ea5d (patch) | |
| tree | 69a5a02e3f480dc9883196b346fc516082b1594c /src | |
| parent | 6e759cefe809cb7852cdf6ea3088d8604a817185 (diff) | |
| download | postgresql-e76e365be9e7fc30f19d21962461a0046d15ea5d.tar.gz postgresql-e76e365be9e7fc30f19d21962461a0046d15ea5d.zip | |
logical decoding: old/newtuple in spooled UPDATE changes was switched around.
Somehow I managed to flip the order of restoring old & new tuples when
de-spooling a change in a large transaction from disk. This happens to
only take effect when a change is spooled to disk which has old/new
versions of the tuple. That only is the case for UPDATEs where he
primary key changed or where replica identity is changed to FULL.
The tests didn't catch this because either spooled updates, or updates
that changed primary keys, were tested; not both at the same time.
Found while adding tests for the following commit.
Backpatch: 9.4, where logical decoding was added
Diffstat (limited to 'src')
| -rw-r--r-- | src/backend/replication/logical/reorderbuffer.c | 20 |
1 files changed, 10 insertions, 10 deletions
diff --git a/src/backend/replication/logical/reorderbuffer.c b/src/backend/replication/logical/reorderbuffer.c index b3276c74c7c..2f4489d1b3e 100644 --- a/src/backend/replication/logical/reorderbuffer.c +++ b/src/backend/replication/logical/reorderbuffer.c @@ -2335,27 +2335,27 @@ ReorderBufferRestoreChange(ReorderBuffer *rb, ReorderBufferTXN *txn, case REORDER_BUFFER_CHANGE_UPDATE: case REORDER_BUFFER_CHANGE_DELETE: case REORDER_BUFFER_CHANGE_INTERNAL_SPEC_INSERT: - if (change->data.tp.newtuple) + if (change->data.tp.oldtuple) { Size len = offsetof(ReorderBufferTupleBuf, t_data) + ((ReorderBufferTupleBuf *) data)->tuple.t_len; - change->data.tp.newtuple = ReorderBufferGetTupleBuf(rb); - memcpy(change->data.tp.newtuple, data, len); - change->data.tp.newtuple->tuple.t_data = - &change->data.tp.newtuple->t_data.header; + change->data.tp.oldtuple = ReorderBufferGetTupleBuf(rb); + memcpy(change->data.tp.oldtuple, data, len); + change->data.tp.oldtuple->tuple.t_data = + &change->data.tp.oldtuple->t_data.header; data += len; } - if (change->data.tp.oldtuple) + if (change->data.tp.newtuple) { Size len = offsetof(ReorderBufferTupleBuf, t_data) + ((ReorderBufferTupleBuf *) data)->tuple.t_len; - change->data.tp.oldtuple = ReorderBufferGetTupleBuf(rb); - memcpy(change->data.tp.oldtuple, data, len); - change->data.tp.oldtuple->tuple.t_data = - &change->data.tp.oldtuple->t_data.header; + change->data.tp.newtuple = ReorderBufferGetTupleBuf(rb); + memcpy(change->data.tp.newtuple, data, len); + change->data.tp.newtuple->tuple.t_data = + &change->data.tp.newtuple->t_data.header; data += len; } break; |