diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2021-06-12 13:29:24 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2021-06-12 13:29:24 -0400 |
| commit | f479ea94bd24e61199fab3596a4a3e7241c6c28c (patch) | |
| tree | 806bc372bb6469c9fbbe3c998e18e36e376aba29 /src | |
| parent | 8b5055812cadd00a86a438fc0d8bafeba3c4d874 (diff) | |
| download | postgresql-f479ea94bd24e61199fab3596a4a3e7241c6c28c.tar.gz postgresql-f479ea94bd24e61199fab3596a4a3e7241c6c28c.zip | |
Ensure pg_filenode_relation(0, 0) returns NULL.
Previously, a zero value for the relfilenode resulted in
a confusing error message about "unexpected duplicate".
This function returns NULL for other invalid relfilenode
values, so zero should be treated likewise.
It's been like this all along, so back-patch to all supported
branches.
Justin Pryzby
Discussion: https://postgr.es/m/20210612023324.GT16435@telsasoft.com
Diffstat (limited to 'src')
| -rw-r--r-- | src/backend/utils/adt/dbsize.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/src/backend/utils/adt/dbsize.c b/src/backend/utils/adt/dbsize.c index 840664429eb..70d7f86c8d0 100644 --- a/src/backend/utils/adt/dbsize.c +++ b/src/backend/utils/adt/dbsize.c @@ -921,7 +921,11 @@ pg_filenode_relation(PG_FUNCTION_ARGS) { Oid reltablespace = PG_GETARG_OID(0); Oid relfilenode = PG_GETARG_OID(1); - Oid heaprel = InvalidOid; + Oid heaprel; + + /* test needed so RelidByRelfilenode doesn't misbehave */ + if (!OidIsValid(relfilenode)) + PG_RETURN_NULL(); heaprel = RelidByRelfilenode(reltablespace, relfilenode); |