diff options
| author | David Rowley <drowley@postgresql.org> | 2022-09-20 09:15:04 +1200 |
|---|---|---|
| committer | David Rowley <drowley@postgresql.org> | 2022-09-20 09:15:04 +1200 |
| commit | f6c70b81802a869303be9916d1a64a15f4dd29d1 (patch) | |
| tree | bc7ecee479cebe0e40e2f82feefe9609b02dd2db /src | |
| parent | 7fbf9b1b07dcfb656d9c389c76ae74dd35542c21 (diff) | |
| download | postgresql-f6c70b81802a869303be9916d1a64a15f4dd29d1.tar.gz postgresql-f6c70b81802a869303be9916d1a64a15f4dd29d1.zip | |
Fix out-dated comment in preprocess_groupclause()
The comment claimed we don't consider other orders of the GROUP BY clause,
but this is no longer true as of db0d67db2.
Discussion: https://postgr.es/m/CAApHDvq65=9Ro+hLX1i9ugWEiNDvHrBibAO7ARcTnf38_JE+UQ@mail.gmail.com
Backpatch-through: 15, where db0d67db2 was introduced.
Diffstat (limited to 'src')
| -rw-r--r-- | src/backend/optimizer/plan/planner.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/backend/optimizer/plan/planner.c b/src/backend/optimizer/plan/planner.c index a0f2390334e..d8e8f607b2b 100644 --- a/src/backend/optimizer/plan/planner.c +++ b/src/backend/optimizer/plan/planner.c @@ -2756,8 +2756,9 @@ remove_useless_groupby_columns(PlannerInfo *root) * * In principle it might be interesting to consider other orderings of the * GROUP BY elements, which could match the sort ordering of other - * possible plans (eg an indexscan) and thereby reduce cost. We don't - * bother with that, though. Hashed grouping will frequently win anyway. + * possible plans (eg an indexscan) and thereby reduce cost. However, we + * don't yet have sufficient information to do that here, so that's left until + * later in planning. See get_useful_group_keys_orderings(). * * Note: we need no comparable processing of the distinctClause because * the parser already enforced that that matches ORDER BY. |