diff options
| author | Andres Freund <andres@anarazel.de> | 2016-03-02 23:42:21 -0800 |
|---|---|---|
| committer | Andres Freund <andres@anarazel.de> | 2016-03-02 23:43:42 -0800 |
| commit | f8a75881f90f88f4dc54f3692e4e1691cf2c0a91 (patch) | |
| tree | 84cd09a785ce39a44985af604a56d21187f4b314 /src | |
| parent | 429d6846572fe43dc11496adfeaecadf23925e3f (diff) | |
| download | postgresql-f8a75881f90f88f4dc54f3692e4e1691cf2c0a91.tar.gz postgresql-f8a75881f90f88f4dc54f3692e4e1691cf2c0a91.zip | |
logical decoding: fix decoding of a commit's commit time.
When adding replication origins in 5aa235042, I somehow managed to set
the timestamp of decoded transactions to InvalidXLogRecptr when decoding
one made without a replication origin. Fix that, and the wrong type of
the new commit_time variable.
This didn't trigger a regression test failure because we explicitly
don't show commit timestamps in the regression tests, as they obviously
are variable. Add a test that checks that a decoded commit's timestamp
is within minutes of NOW() from before the commit.
Reported-By: Weiping Qu
Diagnosed-By: Artur Zakirov
Discussion: 56D4197E.9050706@informatik.uni-kl.de,
56D42918.1010108@postgrespro.ru
Backpatch: 9.5, where 5aa235042 originates.
Diffstat (limited to 'src')
| -rw-r--r-- | src/backend/replication/logical/decode.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/backend/replication/logical/decode.c b/src/backend/replication/logical/decode.c index 9f606875c86..61c3ed740bb 100644 --- a/src/backend/replication/logical/decode.c +++ b/src/backend/replication/logical/decode.c @@ -449,7 +449,7 @@ DecodeCommit(LogicalDecodingContext *ctx, XLogRecordBuffer *buf, xl_xact_parsed_commit *parsed, TransactionId xid) { XLogRecPtr origin_lsn = InvalidXLogRecPtr; - XLogRecPtr commit_time = InvalidXLogRecPtr; + TimestampTz commit_time = parsed->xact_time; XLogRecPtr origin_id = XLogRecGetOrigin(buf->record); int i; |