aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorStephen Frost <sfrost@snowman.net>2016-04-08 16:30:02 -0400
committerStephen Frost <sfrost@snowman.net>2016-04-08 16:30:02 -0400
commitfa6075e5515c6878b2c1fe1c6435dd7ed847857d (patch)
tree63aa817900092f3093511c52de7d5102f9b46f80 /src
parent848ef42bb8c7909c9d7baa38178d4a209906e7c1 (diff)
downloadpostgresql-fa6075e5515c6878b2c1fe1c6435dd7ed847857d.tar.gz
postgresql-fa6075e5515c6878b2c1fe1c6435dd7ed847857d.zip
Fix improper usage of 'dump' bitmap
Now that 'dump' is a bitmap, we can't simply set it to 'true'. Noticed while debugging the prior issue.
Diffstat (limited to 'src')
-rw-r--r--src/bin/pg_dump/pg_dump_sort.c9
1 files changed, 7 insertions, 2 deletions
diff --git a/src/bin/pg_dump/pg_dump_sort.c b/src/bin/pg_dump/pg_dump_sort.c
index 36de6b62573..dc35a937275 100644
--- a/src/bin/pg_dump/pg_dump_sort.c
+++ b/src/bin/pg_dump/pg_dump_sort.c
@@ -848,9 +848,14 @@ repairTypeFuncLoop(DumpableObject *typeobj, DumpableObject *funcobj)
if (typeInfo->shellType)
{
addObjectDependency(funcobj, typeInfo->shellType->dobj.dumpId);
- /* Mark shell type as to be dumped if any such function is */
+ /*
+ * Mark shell type (always including the definition, as we need
+ * the shell type defined to identify the function fully) as to be
+ * dumped if any such function is
+ */
if (funcobj->dump)
- typeInfo->shellType->dobj.dump = true;
+ typeInfo->shellType->dobj.dump = funcobj->dump |
+ DUMP_COMPONENT_DEFINITION;
}
}