aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--src/backend/storage/buffer/bufmgr.c8
-rw-r--r--src/backend/storage/lmgr/lwlock.c4
-rw-r--r--src/backend/storage/lmgr/s_lock.c4
-rw-r--r--src/include/storage/s_lock.h15
4 files changed, 25 insertions, 6 deletions
diff --git a/src/backend/storage/buffer/bufmgr.c b/src/backend/storage/buffer/bufmgr.c
index 47644ea528b..462dd4a2262 100644
--- a/src/backend/storage/buffer/bufmgr.c
+++ b/src/backend/storage/buffer/bufmgr.c
@@ -4029,9 +4029,11 @@ rnode_comparator(const void *p1, const void *p2)
uint32
LockBufHdr(BufferDesc *desc)
{
- SpinDelayStatus delayStatus = init_local_spin_delay();
+ SpinDelayStatus delayStatus;
uint32 old_buf_state;
+ init_local_spin_delay(&delayStatus);
+
while (true)
{
/* set BM_LOCKED flag */
@@ -4055,9 +4057,11 @@ LockBufHdr(BufferDesc *desc)
static uint32
WaitBufHdrUnlocked(BufferDesc *buf)
{
- SpinDelayStatus delayStatus = init_local_spin_delay();
+ SpinDelayStatus delayStatus;
uint32 buf_state;
+ init_local_spin_delay(&delayStatus);
+
buf_state = pg_atomic_read_u32(&buf->state);
while (buf_state & BM_LOCKED)
diff --git a/src/backend/storage/lmgr/lwlock.c b/src/backend/storage/lmgr/lwlock.c
index ddb653a06d7..25eec9800de 100644
--- a/src/backend/storage/lmgr/lwlock.c
+++ b/src/backend/storage/lmgr/lwlock.c
@@ -870,7 +870,9 @@ LWLockWaitListLock(LWLock *lock)
/* and then spin without atomic operations until lock is released */
{
- SpinDelayStatus delayStatus = init_local_spin_delay();
+ SpinDelayStatus delayStatus;
+
+ init_local_spin_delay(&delayStatus);
while (old_state & LW_FLAG_LOCKED)
{
diff --git a/src/backend/storage/lmgr/s_lock.c b/src/backend/storage/lmgr/s_lock.c
index 3902cbf2d96..599940cbd2d 100644
--- a/src/backend/storage/lmgr/s_lock.c
+++ b/src/backend/storage/lmgr/s_lock.c
@@ -91,7 +91,9 @@ s_lock_stuck(const char *file, int line, const char *func)
int
s_lock(volatile slock_t *lock, const char *file, int line, const char *func)
{
- SpinDelayStatus delayStatus = init_spin_delay(file, line, func);
+ SpinDelayStatus delayStatus;
+
+ init_spin_delay(&delayStatus, file, line, func);
while (TAS_SPIN(lock))
{
diff --git a/src/include/storage/s_lock.h b/src/include/storage/s_lock.h
index 50ea5c0eaf7..7aad2de43d0 100644
--- a/src/include/storage/s_lock.h
+++ b/src/include/storage/s_lock.h
@@ -1005,8 +1005,19 @@ typedef struct
const char *func;
} SpinDelayStatus;
-#define init_spin_delay(file, line, func) {0, 0, 0, file, line, func}
-#define init_local_spin_delay() init_spin_delay(__FILE__, __LINE__, PG_FUNCNAME_MACRO)
+static inline void
+init_spin_delay(SpinDelayStatus *status,
+ const char *file, int line, const char *func)
+{
+ status->spins = 0;
+ status->delays = 0;
+ status->cur_delay = 0;
+ status->file = file;
+ status->line = line;
+ status->func = func;
+}
+
+#define init_local_spin_delay(status) init_spin_delay(status, __FILE__, __LINE__, PG_FUNCNAME_MACRO)
void perform_spin_delay(SpinDelayStatus *status);
void finish_spin_delay(SpinDelayStatus *status);