aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--src/backend/utils/misc/guc.c9
1 files changed, 8 insertions, 1 deletions
diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c
index 0d9242307d7..497fd931999 100644
--- a/src/backend/utils/misc/guc.c
+++ b/src/backend/utils/misc/guc.c
@@ -6749,9 +6749,12 @@ set_config_option(const char *name, const char *value,
* Other changes might need to affect other workers, so forbid them.
*/
if (IsInParallelMode() && changeVal && action != GUC_ACTION_SAVE)
+ {
ereport(elevel,
(errcode(ERRCODE_INVALID_TRANSACTION_STATE),
errmsg("cannot set parameters during a parallel operation")));
+ return -1;
+ }
record = find_option(name, true, elevel);
if (record == NULL)
@@ -6841,6 +6844,10 @@ set_config_option(const char *name, const char *value,
* backends. This is a tad klugy, but necessary because we
* don't re-read the config file during backend start.
*
+ * However, if changeVal is false then plow ahead anyway since
+ * we are trying to find out if the value is potentially good,
+ * not actually use it.
+ *
* In EXEC_BACKEND builds, this works differently: we load all
* non-default settings from the CONFIG_EXEC_PARAMS file
* during backend start. In that case we must accept
@@ -6851,7 +6858,7 @@ set_config_option(const char *name, const char *value,
* started it. is_reload will be true when either situation
* applies.
*/
- if (IsUnderPostmaster && !is_reload)
+ if (IsUnderPostmaster && changeVal && !is_reload)
return -1;
}
else if (context != PGC_POSTMASTER &&