aboutsummaryrefslogtreecommitdiff
path: root/src/backend/utils
diff options
context:
space:
mode:
Diffstat (limited to 'src/backend/utils')
-rw-r--r--src/backend/utils/error/elog.c95
-rw-r--r--src/backend/utils/mb/wchar.c27
2 files changed, 69 insertions, 53 deletions
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index b63049bb117..bc6b1327c7c 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -42,7 +42,7 @@
*
*
* IDENTIFICATION
- * $PostgreSQL: pgsql/src/backend/utils/error/elog.c,v 1.201.2.2 2008/10/27 19:37:28 tgl Exp $
+ * $PostgreSQL: pgsql/src/backend/utils/error/elog.c,v 1.201.2.3 2009/03/02 21:18:50 tgl Exp $
*
*-------------------------------------------------------------------------
*/
@@ -72,6 +72,9 @@
#include "utils/ps_status.h"
+#undef _
+#define _(x) err_gettext(x)
+
/* Global variables */
ErrorContextCallback *error_context_stack = NULL;
@@ -152,6 +155,25 @@ in_error_recursion_trouble(void)
}
/*
+ * One of those fallback steps is to stop trying to localize the error
+ * message, since there's a significant probability that that's exactly
+ * what's causing the recursion.
+ */
+static inline const char *
+err_gettext(const char *str)
+{
+#ifdef ENABLE_NLS
+ if (in_error_recursion_trouble())
+ return str;
+ else
+ return gettext(str);
+#else
+ return str;
+#endif
+}
+
+
+/*
* errstart --- begin an error-reporting cycle
*
* Create a stack entry and store the given parameters in it. Subsequently,
@@ -614,7 +636,7 @@ errcode_for_socket_access(void)
char *fmtbuf; \
StringInfoData buf; \
/* Internationalize the error format string */ \
- if (translateit) \
+ if (translateit && !in_error_recursion_trouble()) \
fmt = _(fmt); \
/* Expand %m in format string */ \
fmtbuf = expand_fmt_string(fmt, edata); \
@@ -2083,7 +2105,7 @@ send_message_to_server_log(ErrorData *edata)
}
else
{
- char *msg = _("Not safe to send CSV data\n");
+ const char *msg = _("Not safe to send CSV data\n");
write(fileno(stderr), msg, strlen(msg));
if (!(Log_destination & LOG_DESTINATION_STDERR) &&
@@ -2136,6 +2158,26 @@ write_pipe_chunks(char *data, int len, int dest)
/*
+ * Append a text string to the error report being built for the client.
+ *
+ * This is ordinarily identical to pq_sendstring(), but if we are in
+ * error recursion trouble we skip encoding conversion, because of the
+ * possibility that the problem is a failure in the encoding conversion
+ * subsystem itself. Code elsewhere should ensure that the passed-in
+ * strings will be plain 7-bit ASCII, and thus not in need of conversion,
+ * in such cases. (In particular, we disable localization of error messages
+ * to help ensure that's true.)
+ */
+static void
+err_sendstring(StringInfo buf, const char *str)
+{
+ if (in_error_recursion_trouble())
+ pq_send_ascii_string(buf, str);
+ else
+ pq_sendstring(buf, str);
+}
+
+/*
* Write error report to client
*/
static void
@@ -2154,7 +2196,7 @@ send_message_to_frontend(ErrorData *edata)
int i;
pq_sendbyte(&msgbuf, PG_DIAG_SEVERITY);
- pq_sendstring(&msgbuf, error_severity(edata->elevel));
+ err_sendstring(&msgbuf, error_severity(edata->elevel));
/* unpack MAKE_SQLSTATE code */
ssval = edata->sqlerrcode;
@@ -2166,70 +2208,70 @@ send_message_to_frontend(ErrorData *edata)
tbuf[i] = '\0';
pq_sendbyte(&msgbuf, PG_DIAG_SQLSTATE);
- pq_sendstring(&msgbuf, tbuf);
+ err_sendstring(&msgbuf, tbuf);
/* M field is required per protocol, so always send something */
pq_sendbyte(&msgbuf, PG_DIAG_MESSAGE_PRIMARY);
if (edata->message)
- pq_sendstring(&msgbuf, edata->message);
+ err_sendstring(&msgbuf, edata->message);
else
- pq_sendstring(&msgbuf, _("missing error text"));
+ err_sendstring(&msgbuf, _("missing error text"));
if (edata->detail)
{
pq_sendbyte(&msgbuf, PG_DIAG_MESSAGE_DETAIL);
- pq_sendstring(&msgbuf, edata->detail);
+ err_sendstring(&msgbuf, edata->detail);
}
if (edata->hint)
{
pq_sendbyte(&msgbuf, PG_DIAG_MESSAGE_HINT);
- pq_sendstring(&msgbuf, edata->hint);
+ err_sendstring(&msgbuf, edata->hint);
}
if (edata->context)
{
pq_sendbyte(&msgbuf, PG_DIAG_CONTEXT);
- pq_sendstring(&msgbuf, edata->context);
+ err_sendstring(&msgbuf, edata->context);
}
if (edata->cursorpos > 0)
{
snprintf(tbuf, sizeof(tbuf), "%d", edata->cursorpos);
pq_sendbyte(&msgbuf, PG_DIAG_STATEMENT_POSITION);
- pq_sendstring(&msgbuf, tbuf);
+ err_sendstring(&msgbuf, tbuf);
}
if (edata->internalpos > 0)
{
snprintf(tbuf, sizeof(tbuf), "%d", edata->internalpos);
pq_sendbyte(&msgbuf, PG_DIAG_INTERNAL_POSITION);
- pq_sendstring(&msgbuf, tbuf);
+ err_sendstring(&msgbuf, tbuf);
}
if (edata->internalquery)
{
pq_sendbyte(&msgbuf, PG_DIAG_INTERNAL_QUERY);
- pq_sendstring(&msgbuf, edata->internalquery);
+ err_sendstring(&msgbuf, edata->internalquery);
}
if (edata->filename)
{
pq_sendbyte(&msgbuf, PG_DIAG_SOURCE_FILE);
- pq_sendstring(&msgbuf, edata->filename);
+ err_sendstring(&msgbuf, edata->filename);
}
if (edata->lineno > 0)
{
snprintf(tbuf, sizeof(tbuf), "%d", edata->lineno);
pq_sendbyte(&msgbuf, PG_DIAG_SOURCE_LINE);
- pq_sendstring(&msgbuf, tbuf);
+ err_sendstring(&msgbuf, tbuf);
}
if (edata->funcname)
{
pq_sendbyte(&msgbuf, PG_DIAG_SOURCE_FUNCTION);
- pq_sendstring(&msgbuf, edata->funcname);
+ err_sendstring(&msgbuf, edata->funcname);
}
pq_sendbyte(&msgbuf, '\0'); /* terminator */
@@ -2260,7 +2302,7 @@ send_message_to_frontend(ErrorData *edata)
appendStringInfoChar(&buf, '\n');
- pq_sendstring(&msgbuf, buf.data);
+ err_sendstring(&msgbuf, buf.data);
pfree(buf.data);
}
@@ -2374,10 +2416,6 @@ useful_strerror(int errnum)
/*
* error_severity --- get localized string representing elevel
- *
- * Note: in an error recursion situation, we stop localizing the tags
- * for ERROR and above. This is necessary because the problem might be
- * failure to convert one of these strings to the client encoding.
*/
static const char *
error_severity(int elevel)
@@ -2407,22 +2445,13 @@ error_severity(int elevel)
prefix = _("WARNING");
break;
case ERROR:
- if (in_error_recursion_trouble())
- prefix = "ERROR";
- else
- prefix = _("ERROR");
+ prefix = _("ERROR");
break;
case FATAL:
- if (in_error_recursion_trouble())
- prefix = "FATAL";
- else
- prefix = _("FATAL");
+ prefix = _("FATAL");
break;
case PANIC:
- if (in_error_recursion_trouble())
- prefix = "PANIC";
- else
- prefix = _("PANIC");
+ prefix = _("PANIC");
break;
default:
prefix = "???";
diff --git a/src/backend/utils/mb/wchar.c b/src/backend/utils/mb/wchar.c
index be051aca884..7d69d044669 100644
--- a/src/backend/utils/mb/wchar.c
+++ b/src/backend/utils/mb/wchar.c
@@ -1,7 +1,7 @@
/*
* conversion functions between pg_wchar and multibyte streams.
* Tatsuo Ishii
- * $PostgreSQL: pgsql/src/backend/utils/mb/wchar.c,v 1.66.2.2 2009/01/29 19:23:58 tgl Exp $
+ * $PostgreSQL: pgsql/src/backend/utils/mb/wchar.c,v 1.66.2.3 2009/03/02 21:18:50 tgl Exp $
*
*/
/* can be used in either frontend or backend */
@@ -1600,25 +1600,12 @@ report_untranslatable_char(int src_encoding, int dest_encoding,
for (j = 0; j < jlimit; j++)
p += sprintf(p, "%02x", (unsigned char) mbstr[j]);
- /*
- * In an error recursion situation, don't try to translate the message.
- * This gets us out of trouble if the problem is failure to convert
- * this very message (after translation) to the client encoding.
- */
- if (in_error_recursion_trouble())
- ereport(ERROR,
- (errcode(ERRCODE_UNTRANSLATABLE_CHARACTER),
- errmsg_internal("character 0x%s of encoding \"%s\" has no equivalent in \"%s\"",
- buf,
- pg_enc2name_tbl[src_encoding].name,
- pg_enc2name_tbl[dest_encoding].name)));
- else
- ereport(ERROR,
- (errcode(ERRCODE_UNTRANSLATABLE_CHARACTER),
- errmsg("character 0x%s of encoding \"%s\" has no equivalent in \"%s\"",
- buf,
- pg_enc2name_tbl[src_encoding].name,
- pg_enc2name_tbl[dest_encoding].name)));
+ ereport(ERROR,
+ (errcode(ERRCODE_UNTRANSLATABLE_CHARACTER),
+ errmsg("character 0x%s of encoding \"%s\" has no equivalent in \"%s\"",
+ buf,
+ pg_enc2name_tbl[src_encoding].name,
+ pg_enc2name_tbl[dest_encoding].name)));
}
#endif
generated by cgit v1.2.3 (git 2.25.1) at 2025-08-05 02:13:54 +0000