diff options
Diffstat (limited to 'src')
| -rw-r--r-- | src/backend/replication/logical/decode.c | 2 | ||||
| -rw-r--r-- | src/bin/pg_basebackup/pg_basebackup.c | 9 | ||||
| -rw-r--r-- | src/bin/pg_dump/pg_dump.c | 3 |
3 files changed, 10 insertions, 4 deletions
diff --git a/src/backend/replication/logical/decode.c b/src/backend/replication/logical/decode.c index 9b450c9f90e..3fb5a92a1a1 100644 --- a/src/backend/replication/logical/decode.c +++ b/src/backend/replication/logical/decode.c @@ -498,7 +498,7 @@ heap_decode(LogicalDecodingContext *ctx, XLogRecordBuffer *buf) if (!TransactionIdIsValid(xid)) break; - SnapBuildProcessChange(builder, xid, buf->origptr); + (void) SnapBuildProcessChange(builder, xid, buf->origptr); ReorderBufferXidSetCatalogChanges(ctx->reorder, xid, buf->origptr); break; diff --git a/src/bin/pg_basebackup/pg_basebackup.c b/src/bin/pg_basebackup/pg_basebackup.c index d5b0ade10d5..7a56ebb2c92 100644 --- a/src/bin/pg_basebackup/pg_basebackup.c +++ b/src/bin/pg_basebackup/pg_basebackup.c @@ -948,7 +948,7 @@ parse_compress_options(char *src, WalCompressionMethod *methodres, { char *sep; int firstlen; - char *firstpart = NULL; + char *firstpart; /* check if the option is split in two */ sep = strchr(src, ':'); @@ -959,7 +959,7 @@ parse_compress_options(char *src, WalCompressionMethod *methodres, */ firstlen = (sep != NULL) ? (sep - src) : strlen(src); firstpart = pg_malloc(firstlen + 1); - strncpy(firstpart, src, firstlen); + memcpy(firstpart, src, firstlen); firstpart[firstlen] = '\0'; /* @@ -983,6 +983,8 @@ parse_compress_options(char *src, WalCompressionMethod *methodres, *methodres = (*levelres > 0) ? COMPRESSION_GZIP : COMPRESSION_NONE; + + free(firstpart); return; } @@ -992,6 +994,7 @@ parse_compress_options(char *src, WalCompressionMethod *methodres, * The caller specified a method without a colon separator, so let any * subsequent checks assign a default level. */ + free(firstpart); return; } @@ -1010,6 +1013,8 @@ parse_compress_options(char *src, WalCompressionMethod *methodres, if (!option_parse_int(sep, "-Z/--compress", 0, INT_MAX, levelres)) exit(1); + + free(firstpart); } /* diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c index 7c2f1d30447..7c0e396ce13 100644 --- a/src/bin/pg_dump/pg_dump.c +++ b/src/bin/pg_dump/pg_dump.c @@ -4714,7 +4714,6 @@ binary_upgrade_set_pg_class_oids(Archive *fout, } PQclear(upgrade_res); - destroyPQExpBuffer(upgrade_query); } else { @@ -4728,6 +4727,8 @@ binary_upgrade_set_pg_class_oids(Archive *fout, } appendPQExpBufferChar(upgrade_buffer, '\n'); + + destroyPQExpBuffer(upgrade_query); } /* |