aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
Diffstat (limited to 'src')
-rw-r--r--src/backend/executor/execExprInterp.c6
-rw-r--r--src/test/regress/expected/domain.out23
-rw-r--r--src/test/regress/sql/domain.sql9
3 files changed, 37 insertions, 1 deletions
diff --git a/src/backend/executor/execExprInterp.c b/src/backend/executor/execExprInterp.c
index 0999bba4217..3e0751c9236 100644
--- a/src/backend/executor/execExprInterp.c
+++ b/src/backend/executor/execExprInterp.c
@@ -3917,8 +3917,12 @@ ExecEvalWholeRowVar(ExprState *state, ExprEvalStep *op, ExprContext *econtext)
* generates an INT4 NULL regardless of the dropped column type).
* If we find a dropped column and cannot verify that case (1)
* holds, we have to use the slow path to check (2) for each row.
+ *
+ * If vartype is a domain over composite, just look through that
+ * to the base composite type.
*/
- var_tupdesc = lookup_rowtype_tupdesc(variable->vartype, -1);
+ var_tupdesc = lookup_rowtype_tupdesc_domain(variable->vartype,
+ -1, false);
slot_tupdesc = slot->tts_tupleDescriptor;
diff --git a/src/test/regress/expected/domain.out b/src/test/regress/expected/domain.out
index 579a3d5f13f..d0ead069a42 100644
--- a/src/test/regress/expected/domain.out
+++ b/src/test/regress/expected/domain.out
@@ -283,6 +283,29 @@ Rules:
ON DELETE TO dcomptable DO INSTEAD UPDATE dcomptable SET d1.r = (dcomptable.d1).r - 1::double precision, d1.i = (dcomptable.d1).i + 1::double precision
WHERE (dcomptable.d1).i > 0::double precision
+create function makedcomp(r float8, i float8) returns dcomptype
+as 'select row(r, i)::dcomptype' language sql;
+select makedcomp(1,2);
+ makedcomp
+-----------
+ (1,2)
+(1 row)
+
+select makedcomp(2,1); -- fail
+ERROR: value for domain dcomptype violates check constraint "c1"
+select * from makedcomp(1,2) m;
+ r | i
+---+---
+ 1 | 2
+(1 row)
+
+select m, m is not null from makedcomp(1,2) m;
+ m | ?column?
+-------+----------
+ (1,2) | t
+(1 row)
+
+drop function makedcomp(float8, float8);
drop table dcomptable;
drop type comptype cascade;
NOTICE: drop cascades to type dcomptype
diff --git a/src/test/regress/sql/domain.sql b/src/test/regress/sql/domain.sql
index 55c7cf74533..ad3edcf4067 100644
--- a/src/test/regress/sql/domain.sql
+++ b/src/test/regress/sql/domain.sql
@@ -155,6 +155,15 @@ create rule silly as on delete to dcomptable do instead
update dcomptable set d1.r = (d1).r - 1, d1.i = (d1).i + 1 where (d1).i > 0;
\d+ dcomptable
+create function makedcomp(r float8, i float8) returns dcomptype
+as 'select row(r, i)::dcomptype' language sql;
+
+select makedcomp(1,2);
+select makedcomp(2,1); -- fail
+select * from makedcomp(1,2) m;
+select m, m is not null from makedcomp(1,2) m;
+
+drop function makedcomp(float8, float8);
drop table dcomptable;
drop type comptype cascade;