diff options
Diffstat (limited to 'src')
-rw-r--r-- | src/backend/access/transam/multixact.c | 3 | ||||
-rw-r--r-- | src/backend/commands/define.c | 7 | ||||
-rw-r--r-- | src/backend/optimizer/plan/subselect.c | 8 | ||||
-rw-r--r-- | src/backend/parser/parse_type.c | 3 | ||||
-rw-r--r-- | src/backend/storage/smgr/md.c | 4 | ||||
-rw-r--r-- | src/backend/utils/adt/date.c | 6 | ||||
-rw-r--r-- | src/backend/utils/adt/timestamp.c | 7 | ||||
-rw-r--r-- | src/backend/utils/fmgr/funcapi.c | 3 | ||||
-rw-r--r-- | src/test/regress/regress.c | 6 | ||||
-rw-r--r-- | src/tutorial/complex.c | 3 |
10 files changed, 13 insertions, 37 deletions
diff --git a/src/backend/access/transam/multixact.c b/src/backend/access/transam/multixact.c index e2b31ee441f..6ab53840f8e 100644 --- a/src/backend/access/transam/multixact.c +++ b/src/backend/access/transam/multixact.c @@ -2757,8 +2757,7 @@ pg_get_multixact_members(PG_FUNCTION_ARGS) HeapTuple tuple; char *values[2]; - values[0] = palloc(32); - sprintf(values[0], "%u", multi->members[multi->iter].xid); + values[0] = psprintf("%u", multi->members[multi->iter].xid); values[1] = mxstatus_to_string(multi->members[multi->iter].status); tuple = BuildTupleFromCStrings(funccxt->attinmeta, values); diff --git a/src/backend/commands/define.c b/src/backend/commands/define.c index 75f77da2cff..486ef924922 100644 --- a/src/backend/commands/define.c +++ b/src/backend/commands/define.c @@ -56,12 +56,7 @@ defGetString(DefElem *def) switch (nodeTag(def->arg)) { case T_Integer: - { - char *str = palloc(32); - - snprintf(str, 32, "%ld", (long) intVal(def->arg)); - return str; - } + return psprintf("%ld", (long) intVal(def->arg)); case T_Float: /* diff --git a/src/backend/optimizer/plan/subselect.c b/src/backend/optimizer/plan/subselect.c index 0f921186609..70fdb14085e 100644 --- a/src/backend/optimizer/plan/subselect.c +++ b/src/backend/optimizer/plan/subselect.c @@ -778,10 +778,7 @@ build_subplan(PlannerInfo *root, Plan *plan, PlannerInfo *subroot, sprintf(splan->plan_name + offset, ")"); } else - { - splan->plan_name = palloc(32); - sprintf(splan->plan_name, "SubPlan %d", splan->plan_id); - } + splan->plan_name = psprintf("SubPlan %d", splan->plan_id); /* Lastly, fill in the cost estimates for use later */ cost_subplan(root, splan, plan); @@ -2600,8 +2597,7 @@ SS_make_initplan_from_plan(PlannerInfo *root, Plan *plan, node->setParam = list_make1_int(prm->paramid); /* Label the subplan for EXPLAIN purposes */ - node->plan_name = palloc(64); - sprintf(node->plan_name, "InitPlan %d (returns $%d)", + node->plan_name = psprintf("InitPlan %d (returns $%d)", node->plan_id, prm->paramid); return prm; diff --git a/src/backend/parser/parse_type.c b/src/backend/parser/parse_type.c index ee6802a6558..84ec8a70e76 100644 --- a/src/backend/parser/parse_type.c +++ b/src/backend/parser/parse_type.c @@ -313,8 +313,7 @@ typenameTypeMod(ParseState *pstate, const TypeName *typeName, Type typ) if (IsA(&ac->val, Integer)) { - cstr = (char *) palloc(32); - snprintf(cstr, 32, "%ld", (long) ac->val.val.ival); + cstr = psprintf("%ld", (long) ac->val.val.ival); } else if (IsA(&ac->val, Float) || IsA(&ac->val, String)) diff --git a/src/backend/storage/smgr/md.c b/src/backend/storage/smgr/md.c index e62918195ea..268035ca92a 100644 --- a/src/backend/storage/smgr/md.c +++ b/src/backend/storage/smgr/md.c @@ -1649,9 +1649,7 @@ _mdfd_segpath(SMgrRelation reln, ForkNumber forknum, BlockNumber segno) if (segno > 0) { - /* be sure we have enough space for the '.segno' */ - fullpath = (char *) palloc(strlen(path) + 12); - sprintf(fullpath, "%s.%u", path, segno); + fullpath = psprintf("%s.%u", path, segno); pfree(path); } else diff --git a/src/backend/utils/adt/date.c b/src/backend/utils/adt/date.c index fe091daec81..2bafd6145c2 100644 --- a/src/backend/utils/adt/date.c +++ b/src/backend/utils/adt/date.c @@ -91,14 +91,12 @@ anytime_typmodin(bool istz, ArrayType *ta) static char * anytime_typmodout(bool istz, int32 typmod) { - char *res = (char *) palloc(64); const char *tz = istz ? " with time zone" : " without time zone"; if (typmod >= 0) - snprintf(res, 64, "(%d)%s", (int) typmod, tz); + return psprintf("(%d)%s", (int) typmod, tz); else - snprintf(res, 64, "%s", tz); - return res; + return psprintf("%s", tz); } diff --git a/src/backend/utils/adt/timestamp.c b/src/backend/utils/adt/timestamp.c index c3c71b72810..5263d807671 100644 --- a/src/backend/utils/adt/timestamp.c +++ b/src/backend/utils/adt/timestamp.c @@ -116,15 +116,12 @@ anytimestamp_typmodin(bool istz, ArrayType *ta) static char * anytimestamp_typmodout(bool istz, int32 typmod) { - char *res = (char *) palloc(64); const char *tz = istz ? " with time zone" : " without time zone"; if (typmod >= 0) - snprintf(res, 64, "(%d)%s", (int) typmod, tz); + return psprintf("(%d)%s", (int) typmod, tz); else - snprintf(res, 64, "%s", tz); - - return res; + return psprintf("%s", tz); } diff --git a/src/backend/utils/fmgr/funcapi.c b/src/backend/utils/fmgr/funcapi.c index 6347a8f1ac3..7718f43da4a 100644 --- a/src/backend/utils/fmgr/funcapi.c +++ b/src/backend/utils/fmgr/funcapi.c @@ -1205,8 +1205,7 @@ build_function_result_tupdesc_d(Datum proallargtypes, if (pname == NULL || pname[0] == '\0') { /* Parameter is not named, so gin up a column name */ - pname = (char *) palloc(32); - snprintf(pname, 32, "column%d", numoutargs + 1); + pname = psprintf("column%d", numoutargs + 1); } outargnames[numoutargs] = pname; numoutargs++; diff --git a/src/test/regress/regress.c b/src/test/regress/regress.c index 3bd8a152859..4dbe314557e 100644 --- a/src/test/regress/regress.c +++ b/src/test/regress/regress.c @@ -269,15 +269,11 @@ widget_in(char *str) char * widget_out(WIDGET * widget) { - char *result; - if (widget == NULL) return NULL; - result = (char *) palloc(60); - sprintf(result, "(%g,%g,%g)", + return psprintf("(%g,%g,%g)", widget->center.x, widget->center.y, widget->radius); - return result; } PG_FUNCTION_INFO_V1(pt_in_widget); diff --git a/src/tutorial/complex.c b/src/tutorial/complex.c index edae0065c7d..80655885d50 100644 --- a/src/tutorial/complex.c +++ b/src/tutorial/complex.c @@ -73,8 +73,7 @@ complex_out(PG_FUNCTION_ARGS) Complex *complex = (Complex *) PG_GETARG_POINTER(0); char *result; - result = (char *) palloc(100); - snprintf(result, 100, "(%g,%g)", complex->x, complex->y); + result = psprintf("(%g,%g)", complex->x, complex->y); PG_RETURN_CSTRING(result); } |