1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
|
# Copyright (c) 2025, PostgreSQL Global Development Group
# Tests for handling the default char signedness during upgrade.
use strict;
use warnings FATAL => 'all';
use PostgreSQL::Test::Cluster;
use PostgreSQL::Test::Utils;
use Test::More;
# Can be changed to test the other modes
my $mode = $ENV{PG_TEST_PG_UPGRADE_MODE} || '--copy';
# Initialize old and new clusters
my $old = PostgreSQL::Test::Cluster->new('old');
my $new = PostgreSQL::Test::Cluster->new('new');
$old->init();
$new->init();
# Check the default char signedness of both the old and the new clusters.
# Newly created clusters unconditionally use 'signed'.
command_like(
[ 'pg_controldata', $old->data_dir ],
qr/Default char data signedness:\s+signed/,
'default char signedness of old cluster is signed in control file');
command_like(
[ 'pg_controldata', $new->data_dir ],
qr/Default char data signedness:\s+signed/,
'default char signedness of new cluster is signed in control file');
# Set the old cluster's default char signedness to unsigned for test.
command_ok(
[
'pg_resetwal',
'--char-signedness' => 'unsigned',
'--force',
$old->data_dir
],
"set old cluster's default char signedness to unsigned");
# Check if the value is successfully updated.
command_like(
[ 'pg_controldata', $old->data_dir ],
qr/Default char data signedness:\s+unsigned/,
'updated default char signedness is unsigned in control file');
# In a VPATH build, we'll be started in the source directory, but we want
# to run pg_upgrade in the build directory so that any files generated finish
# in it, like delete_old_cluster.{sh,bat}.
chdir ${PostgreSQL::Test::Utils::tmp_check};
# Cannot use --set-char-signedness option for upgrading from v18+
command_checks_all(
[
'pg_upgrade', '--no-sync',
'--old-datadir' => $old->data_dir,
'--new-datadir' => $new->data_dir,
'--old-bindir' => $old->config_data('--bindir'),
'--new-bindir' => $new->config_data('--bindir'),
'--socketdir' => $new->host,
'--old-port' => $old->port,
'--new-port' => $new->port,
'--set-char-signedness' => 'signed',
$mode
],
1,
[qr/--set-char-signedness option cannot be used/],
[],
'--set-char-signedness option cannot be used for upgrading from v18 or later'
);
# pg_upgrade should be successful.
command_ok(
[
'pg_upgrade', '--no-sync',
'--old-datadir' => $old->data_dir,
'--new-datadir' => $new->data_dir,
'--old-bindir' => $old->config_data('--bindir'),
'--new-bindir' => $new->config_data('--bindir'),
'--socketdir' => $new->host,
'--old-port' => $old->port,
'--new-port' => $new->port,
$mode
],
'run of pg_upgrade');
# Check if the default char signedness of the new cluster inherited
# the old cluster's value.
command_like(
[ 'pg_controldata', $new->data_dir ],
qr/Default char data signedness:\s+unsigned/,
'the default char signedness is updated during pg_upgrade');
done_testing();
|