diff options
| author | drh <> | 2024-04-05 13:56:05 +0000 |
|---|---|---|
| committer | drh <> | 2024-04-05 13:56:05 +0000 |
| commit | b411c4d69e1d7df018e9c313e104e973fc79d583 (patch) | |
| tree | 27932b1759dbb5b618fd4abb4006b66f0b33fc44 /src | |
| parent | 65a1d7a28464a62488d4771dcbdb35cafa5a4e39 (diff) | |
| download | sqlite-b411c4d69e1d7df018e9c313e104e973fc79d583.tar.gz sqlite-b411c4d69e1d7df018e9c313e104e973fc79d583.zip | |
Check-in [a9657c87c53c1922] is wrong: the IndexedExpr.bMaybeNullRow flag is
required for virtual columns if they are part of an outer join. Add a
test case (derived from dbsqlfuzz b9e65e2f110df998f1306571fae7af6c01e4d92b)
to prove it.
FossilOrigin-Name: 4484ec6d26b31305e31de89bdbae26344d8083a7e7de20861430d31737d9979c
Diffstat (limited to 'src')
| -rw-r--r-- | src/where.c | 8 |
1 files changed, 1 insertions, 7 deletions
diff --git a/src/where.c b/src/where.c index a4506602a..a1837b587 100644 --- a/src/where.c +++ b/src/where.c @@ -5948,16 +5948,10 @@ static SQLITE_NOINLINE void whereAddIndexedExpr( for(i=0; i<pIdx->nColumn; i++){ Expr *pExpr; int j = pIdx->aiColumn[i]; - int bMaybeNullRow; if( j==XN_EXPR ){ pExpr = pIdx->aColExpr->a[i].pExpr; - testcase( pTabItem->fg.jointype & JT_LEFT ); - testcase( pTabItem->fg.jointype & JT_RIGHT ); - testcase( pTabItem->fg.jointype & JT_LTORJ ); - bMaybeNullRow = (pTabItem->fg.jointype & (JT_LEFT|JT_LTORJ|JT_RIGHT))!=0; }else if( j>=0 && (pTab->aCol[j].colFlags & COLFLAG_VIRTUAL)!=0 ){ pExpr = sqlite3ColumnExpr(pTab, &pTab->aCol[j]); - bMaybeNullRow = 0; }else{ continue; } @@ -5989,7 +5983,7 @@ static SQLITE_NOINLINE void whereAddIndexedExpr( p->iDataCur = pTabItem->iCursor; p->iIdxCur = iIdxCur; p->iIdxCol = i; - p->bMaybeNullRow = bMaybeNullRow; + p->bMaybeNullRow = (pTabItem->fg.jointype & (JT_LEFT|JT_LTORJ|JT_RIGHT))!=0; if( sqlite3IndexAffinityStr(pParse->db, pIdx) ){ p->aff = pIdx->zColAff[i]; } |