aboutsummaryrefslogtreecommitdiff
path: root/src/backend/commands/extension.c
diff options
context:
space:
mode:
authorNoah Misch <noah@leadboat.com>2023-07-31 17:04:47 -0700
committerNoah Misch <noah@leadboat.com>2023-07-31 17:04:47 -0700
commit7c5c4e1c0396b0617a6f9b659dd7375fb0bfb9dc (patch)
tree2b6b8d440c7d7f3fdbd914d5c2db1829229ede4e /src/backend/commands/extension.c
parentc9af054653077699189884c336a65e23a7c8aebb (diff)
downloadpostgresql-7c5c4e1c0396b0617a6f9b659dd7375fb0bfb9dc.tar.gz
postgresql-7c5c4e1c0396b0617a6f9b659dd7375fb0bfb9dc.zip
Remove PushOverrideSearchPath() and PopOverrideSearchPath().
Since commit 681d9e4621aac0a9c71364b6f54f00f6d8c4337f, they have no in-tree calls. Any new calls would introduce security vulnerabilities like the one fixed in that commit. Alexander Lakhin, reviewed by Aleksander Alekseev. Discussion: https://postgr.es/m/8ffb4650-52c4-6a81-38fc-8f99be981130@gmail.com
Diffstat (limited to 'src/backend/commands/extension.c')
-rw-r--r--src/backend/commands/extension.c5
1 files changed, 0 insertions, 5 deletions
diff --git a/src/backend/commands/extension.c b/src/backend/commands/extension.c
index 9a2ee1c6008..4cc994ca31e 100644
--- a/src/backend/commands/extension.c
+++ b/src/backend/commands/extension.c
@@ -967,11 +967,6 @@ execute_extension_script(Oid extensionOid, ExtensionControlFile *control,
* searched anyway. (Listing pg_catalog explicitly in a non-first
* position would be bad for security.) Finally add pg_temp to ensure
* that temp objects can't take precedence over others.
- *
- * Note: it might look tempting to use PushOverrideSearchPath for this,
- * but we cannot do that. We have to actually set the search_path GUC in
- * case the extension script examines or changes it. In any case, the
- * GUC_ACTION_SAVE method is just as convenient.
*/
initStringInfo(&pathbuf);
appendStringInfoString(&pathbuf, quote_identifier(schemaName));