aboutsummaryrefslogtreecommitdiff
path: root/src/backend/parser/parse_expr.c
diff options
context:
space:
mode:
authorPeter Eisentraut <peter@eisentraut.org>2022-07-13 11:40:00 +0200
committerPeter Eisentraut <peter@eisentraut.org>2022-07-13 11:43:40 +0200
commit503e3833ef240c94e114be8703046d52f24da021 (patch)
tree5a8ef2aded96066ae2beb0409c0147d30ba1b038 /src/backend/parser/parse_expr.c
parent7057bf23546868ee5f1d9721e7129fb636aab042 (diff)
downloadpostgresql-503e3833ef240c94e114be8703046d52f24da021.tar.gz
postgresql-503e3833ef240c94e114be8703046d52f24da021.zip
Remove useless assertions
We don't need Assert(IsA(foo, String)) right before running strVal(foo), since strVal() already does the assertion internally (via castNode()).
Diffstat (limited to 'src/backend/parser/parse_expr.c')
-rw-r--r--src/backend/parser/parse_expr.c10
1 files changed, 0 insertions, 10 deletions
diff --git a/src/backend/parser/parse_expr.c b/src/backend/parser/parse_expr.c
index 1dbdba93daa..b1cc6a382f1 100644
--- a/src/backend/parser/parse_expr.c
+++ b/src/backend/parser/parse_expr.c
@@ -631,7 +631,6 @@ transformColumnRef(ParseState *pstate, ColumnRef *cref)
{
Node *field1 = (Node *) linitial(cref->fields);
- Assert(IsA(field1, String));
colname = strVal(field1);
/* Try to identify as an unqualified column */
@@ -664,7 +663,6 @@ transformColumnRef(ParseState *pstate, ColumnRef *cref)
Node *field1 = (Node *) linitial(cref->fields);
Node *field2 = (Node *) lsecond(cref->fields);
- Assert(IsA(field1, String));
relname = strVal(field1);
/* Locate the referenced nsitem */
@@ -685,7 +683,6 @@ transformColumnRef(ParseState *pstate, ColumnRef *cref)
break;
}
- Assert(IsA(field2, String));
colname = strVal(field2);
/* Try to identify as a column of the nsitem */
@@ -712,9 +709,7 @@ transformColumnRef(ParseState *pstate, ColumnRef *cref)
Node *field2 = (Node *) lsecond(cref->fields);
Node *field3 = (Node *) lthird(cref->fields);
- Assert(IsA(field1, String));
nspname = strVal(field1);
- Assert(IsA(field2, String));
relname = strVal(field2);
/* Locate the referenced nsitem */
@@ -735,7 +730,6 @@ transformColumnRef(ParseState *pstate, ColumnRef *cref)
break;
}
- Assert(IsA(field3, String));
colname = strVal(field3);
/* Try to identify as a column of the nsitem */
@@ -764,11 +758,8 @@ transformColumnRef(ParseState *pstate, ColumnRef *cref)
Node *field4 = (Node *) lfourth(cref->fields);
char *catname;
- Assert(IsA(field1, String));
catname = strVal(field1);
- Assert(IsA(field2, String));
nspname = strVal(field2);
- Assert(IsA(field3, String));
relname = strVal(field3);
/*
@@ -798,7 +789,6 @@ transformColumnRef(ParseState *pstate, ColumnRef *cref)
break;
}
- Assert(IsA(field4, String));
colname = strVal(field4);
/* Try to identify as a column of the nsitem */